Re: [vserver] [PATCH] support for busybox grep and busybox shell

Natanael Copa wrote:
> Hi,
>
> Those patches was needed to be able to run vserver with busybox grep and
> busybox ash as shell.
>
> The shell patch should not be needed with the next release of busybox.

You realize you could just set /etc/vservers/.defaults/shell to whatever
you want, right? That's the ENTER_SHELL test...

> There are more issues with busybox (mktemp does not work) but this is a
> start.
>
> PS. as a sidenote... it would be awesome if we could get rid of bash and
> have POSIX compliant shell code. See the BUGS section in bash manpage. I
> would be glad to help out in converting the scripts and get rid of some
> other bloat.

I like the bashisms. They mean we get a defined working environment, so
shells different interpretations of POSIX or whatever don't affect us...
That said, I'm not entirely opposed to the idea, given that POSIX-sh
doesn't make the scripts more complicated or harder to read...

> Natanael Copa

The grep patch looks sane, thanks.

-- 
Daniel Hokka Zakrisson