Re: [vserver] Kernel compile warnings

From: Herbert Poetzl <herbert_at_13thfloor.at>
Date: Fri 29 Dec 2017 - 15:11:13 GMT
Message-ID: <20171229151113.GA11489@MAIL.13thfloor.at>

On Fri, Dec 29, 2017 at 10:13:19AM +0100, Ghislain Adnet wrote:
> proc_xid_iterate is called only in proc_xid_file_operations

> find /vservers/kernel/linux-4.1.48/ -type f -exec grep -H proc_xid_iterate {} \;
> /vservers/kernel/linux-4.1.48/kernel/vserver/proc.c:static int proc_xid_iterate(struct file *filp, struct dir_context *ctx)

> /vservers/kernel/linux-4.1.48/kernel/vserver/proc.c-static struct file_operations proc_xid_file_operations = {
> /vservers/kernel/linux-4.1.48/kernel/vserver/proc.c- .read = generic_read_dir,
> /vservers/kernel/linux-4.1.48/kernel/vserver/proc.c: .iterate = proc_xid_iterate,

> but

> seems the function proc_xid_file_operations is not called anywhere:

> find /vservers/kernel/linux-4.1.48 -type f -exec grep -H proc_xid_file_operations {} \;

> /vservers/kernel/linux-4.1.48/patch-4.1.48-vs2.3.8.6.diff:+static struct file_operations proc_xid_file_operations = {
> /vservers/kernel/linux-4.1.48/kernel/vserver/proc.c:static struct file_operations proc_xid_file_operations = {

> so perhaps its legacy code not used anywhere ?

Yep, seems like it.

Try to simply remove the proc_xid_file_operations struct
and see how that works for you (most likely it will compile
just fine which in turn means that you can get rid of the
proc_xid_iterate as well.

Thanks for investigating this and
all the best,
Herbert

> regards,
> Ghislain.
Received on Fri Dec 29 15:09:20 2017

[Next/Previous Months] [Main vserver Project Homepage] [Howto Subscribe/Unsubscribe] [Paul Sladen's vserver stuff]
Generated on Fri 29 Dec 2017 - 15:09:20 GMT by hypermail 2.1.8