Re: [vserver] Linux 3.13.1 Patch for Testing ...

On Saturday 01 of February 2014, Herbert Poetzl wrote:

> Back to positive thinking and good news: a first patch [2]
> for 3.13.1 is now available for testing, please let me
> know if you encounter any issues or hit any specific
> problems with it.

Fails to build here with PID namespace enabled. Upstream change:

commit c2b1df2eb42978073ec27c99cc199d20ae48b849
Author: Andy Lutomirski <luto@amacapital.net>
Date: Thu Aug 22 11:39:16 2013 -0700

    Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children
    
    nsproxy.pid_ns is *not* the task's pid namespace. The name should clarify
    that.
    
    This makes it more obvious that setns on a pid namespace is weird --
    it won't change the pid namespace shown in procfs.

so some verification if vs was using this correctly is probably sensible. If
it was then rename should be enough.

  CC [M] sound/core/seq/seq_timer.o
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:
In function 'vs_mix_nsproxy':
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:150:20:
error: 'struct nsproxy' has no member named 'pid_ns'
   old_pid = nsproxy->pid_ns;
                    ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:151:10:
error: 'struct nsproxy' has no member named 'pid_ns'
   nsproxy->pid_ns = new_nsproxy->pid_ns;
          ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:151:32:
error: 'struct nsproxy' has no member named 'pid_ns'
   nsproxy->pid_ns = new_nsproxy->pid_ns;
                                ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:152:14:
error: 'struct nsproxy' has no member named 'pid_ns'
   if (nsproxy->pid_ns)
              ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:153:22:
error: 'struct nsproxy' has no member named 'pid_ns'
    get_pid_ns(nsproxy->pid_ns);
                      ^
  CC arch/x86/kernel/sysfb_efi.o
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/scripts/Makefile.build:308:
recipe for target 'kernel/vserver/space.o' failed
make[4]: *** [kernel/vserver/space.o] Error 1
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/scripts/Makefile.build:455:
recipe for target 'kernel/vserver' failed
make[3]: *** [kernel/vserver] Error 2
make[3]: *** Waiting for unfinished jobs....

-- 
Arkadiusz Miśkiewicz, arekm / maven.pl