Re: [Vserver] ppc64 utsname patch

From: Herbert Poetzl <herbert_at_13thfloor.at>
Date: Wed 09 Nov 2005 - 15:48:40 GMT
Message-ID: <20051109154840.GB1012@MAIL.13thfloor.at>

On Tue, Nov 08, 2005 at 12:32:31PM -0600, Serge Hallyn wrote:
> Hi,
>
> The following patch is needed for utsname to be properly supported
> on ppc64. Bug was found by testme.sh #031 :)

great! I think I should extend the test*.sh series
pretty soon (have some older scripts lying around
somewhere, which could test 'other' aspects too)

even better! because this is the first report of
a ppc64 system running linux-vserver ...

could you test the 64/32 bit compatibility too?
(should allow 32bit ppc guests on 64bit hosts)

TIA,
Herbert

> (This patch is against the 2.6.14-vs2.2 patch)
>
> thanks,
> -serge
>
> Index: linux-2.6.14/arch/ppc64/kernel/syscalls.c
> ===================================================================
> --- linux-2.6.14.orig/arch/ppc64/kernel/syscalls.c 2005-10-27 19:02:08.000000000 -0500
> +++ linux-2.6.14/arch/ppc64/kernel/syscalls.c 2005-11-08 12:13:42.000000000 -0600
> @@ -37,6 +37,7 @@
> #include <linux/file.h>
> #include <linux/init.h>
> #include <linux/personality.h>
> +#include <linux/vs_cvirt.h>
>
> #include <asm/uaccess.h>
> #include <asm/ipc.h>
> @@ -213,7 +214,7 @@ long ppc64_newuname(struct new_utsname _
> int err = 0;
>
> down_read(&uts_sem);
> - if (copy_to_user(name, &system_utsname, sizeof(*name)))
> + if (copy_to_user(name, vx_new_utsname(), sizeof(*name)))
> err = -EFAULT;
> up_read(&uts_sem);
> if (!err && personality(current->personality) == PER_LINUX32) {
> _______________________________________________
> Vserver mailing list
> Vserver@list.linux-vserver.org
> http://list.linux-vserver.org/mailman/listinfo/vserver
_______________________________________________
Vserver mailing list
Vserver@list.linux-vserver.org
http://list.linux-vserver.org/mailman/listinfo/vserver
Received on Wed Nov 9 15:49:05 2005

[Next/Previous Months] [Main vserver Project Homepage] [Howto Subscribe/Unsubscribe] [Paul Sladen's vserver stuff]
Generated on Wed 09 Nov 2005 - 15:49:10 GMT by hypermail 2.1.8