About this list Date view Thread view Subject view Author view Attachment view

From: Björn Steinbrink (B.Steinbrink_at_gmx.de)
Date: Fri 20 May 2005 - 01:08:22 BST

On 2005.05.20 11:47:27 +1200, Michal Ludvig wrote:
> Björn Steinbrink wrote:
> > Most of the differences are due to the *_mm_counter macros, which I
> > modified to call the Linux-VServer accounting stuff.
> That was on my TODO list as well, but I probably wouldn't come up with
> such a smart "abuse" of preprocessor as you did ;-)
> #define inc_mm_counter(mm, member) vx_ ## member ## pages_inc((mm))

The flowers go to Bertl as well, as I didn't know how to get the
"member" thing in there (i.e. I didn't know the ## thingy) ;)

> > There are two or three other small issues, IIRC QUOTA_CTL and rss
> > accounting, a diff between the ports tells you more ;)
> How could I have missed the quota thing? Hmmm...

Shit happens... It took me 2 or 3 ports until i noticed that the above
macro stuff would be a lot easier than fixing all the hunks ;)

> But I couldn't find any difference in the rss accounting.

IIRC you didn't comment an inc_mm_counter somewhere, so that the counter
gets increased twice.

> > I wondered about that change you did in get_tid_list:
> >
> > - tids[nr_tids] = vx_map_pid(tid);
> > - nr_tids++;
> > + tids[nr_tids++] = vx_map_pid(tid);
> >
> > It looks quite good I'd say, was that a known bug in 2.6.12-rc4?
> I don't think it is known (not fixed in recent git repository). I'm
> about to report it. But 'tids' should be !NULL anyway so there is only a
> small chance to get the counter wrong even without fixing it.


Thanks again
Vserver mailing list

About this list Date view Thread view Subject view Author view Attachment view
[Next/Previous Months] [Main vserver Project Homepage] [Howto Subscribe/Unsubscribe] [Paul Sladen's vserver stuff]
Generated on Fri 20 May 2005 - 01:08:47 BST by hypermail 2.1.3