About this list Date view Thread view Subject view Author view Attachment view

From: Björn Steinbrink (B.Steinbrink_at_gmx.de)
Date: Thu 19 May 2005 - 10:44:20 BST

Hi Michal!

On 2005.05.19 17:21:44 +1200, Michal Ludvig wrote:
> Hi all,
> for anyone interested I did a patch of VServer 2.0-rc1 for the linux
> kernel 2.6.12-rc4. Get here: http://www.logix.cz/michal/devel/vserver/

Great, lLooks quite good :) Updated my port from pre4 to rc1 [1] to check
for differences.
Most of the differences are due to the *_mm_counter macros, which I
modified to call the Linux-VServer accounting stuff. And some whitespace
noise (from both of us I guess, didn't check, but I know that I cause some
every now and then ;).

> It compiles, boots and runs two quite loaded vservers without problems.
> Most of the conflicts were quite easy to solve except for
> net/sunrpc/auth_unix.c, where some fields were removed from 'struct
> unx_cred' and I didn't know where to place 'uc_pxid'. So I omitted it
> completely (yes, I know, that's not a solution, but I don't use NFS
> anyway ;-)

Well, I also left it out, as the NFS_MOUNT_BROKEN_SUID stuff is gone in
2.6.12-rc4 ;)

> Another issue I had with fs/nfs/inode.c where I didn't know how to
> initialize clnt->cl_tagxid.

The handling of mount flags was moved around a bit, nfs_sb_init() is the
place where it happens now...

> The rest was pretty obvious and unless you use NFS on your vserver you
> should be safe to try this patch.

There are two or three other small issues, IIRC QUOTA_CTL and rss
accounting, a diff between the ports tells you more ;)

> Enjoy but don't complain if it wipes your disk! (you've been warned :-)

Hehe :)

I wondered about that change you did in get_tid_list:

- tids[nr_tids] = vx_map_pid(tid);
- nr_tids++;
+ tids[nr_tids++] = vx_map_pid(tid);

It looks quite good I'd say, was that a known bug in 2.6.12-rc4?

Anyways, good job! Having different people (not too many ;) doing ports
can help to find flaws. (And of course Bertl doesn't have to do all the
work then ;)


[1] http://www.13thfloor.at/~doener/vserver/patches/patch-2.6.12-rc4-vs2.0-rc1.diff
Vserver mailing list

About this list Date view Thread view Subject view Author view Attachment view
[Next/Previous Months] [Main vserver Project Homepage] [Howto Subscribe/Unsubscribe] [Paul Sladen's vserver stuff]
Generated on Thu 19 May 2005 - 10:45:36 BST by hypermail 2.1.3