From: Velu Erwan (erwan_at_seanodes.com)
Date: Sun 20 Feb 2005 - 22:02:55 GMT
Enrico Scholz a écrit :
First thing, thanks to handle my patch so quickly.
>I would prefer a shorter 'mandrake' here ;)
>
>
>
Everyone prefer mandrake but the real name is Mandrakelinux.
>I do not know if urpmi supports this, but it should be possible to
>specify the version of Mandrake Linux. E.g.
>
>| vserver ... build -m urpmi -- -d mdk10
>
>
>
Of course it could be done, but the main idea was to install the vserver
using the virtual basesystem rpm (available on all mandrakelinux release).
>>--- distrib/mandrakelinux/pubkeys/pubkey 1970-01-01 01:00:00.000000000 +0100
>>+++ distrib/mandrakelinux/pubkeys/pubkey 2005-02-19 17:38:49.000000000 +0100
>>
>>
>
>I am not sure if I should ship foreign gpg keys in my package. Copying
>the keys from existing pacakges at %post time would be probably the
>better solution.
>
>
They will never change so it could be cool to provide it.
>>diff -Nrub usr/lib/util-vserver/functions /usr/lib/util-vserver/functions
>>--- scripts/functions 2005-02-19 17:54:19.038580040 +0100
>>+++ scripts/functions 2005-02-19 17:51:22.203463064 +0100
>>@@ -236,7 +236,7 @@
>> if test -z "$WORKAROUND_106057"; then
>> _rpmdb_mntpoint=/dev
>> else
>>- _rpmdb_mntpoint=/.rpmdb
>>+ _rpmdb_mntpoint=$BASEDIR/.rpmdb
>>
>>
>
>This does not look sane. The rpm-database mountpoint MUST be at the / of
>the vserver.
>
>
I must assume that some hack were introduce but certainly because I
didn't catch everything in vserver's architecture.
>>+_VURPMI="$SBINDIR/urpmi"
>>
>>
>
>path should be determined in %configure. And the variable should be
>named '_URPMI', not '_VURPMI'.
>
>
Once again a lake in the the global knoweldge :/
> ~~~~~~~~~~~
>This does not seem to be used consistently; below you have 'urpmi.repos.d'
>
>
>
I've copy that from yum, I'm not even sure its usefull for urpmi.
>>+function urpmi.initDB
>>+{
>>+ rm -rf $1/var/lib/rpm
>>+ mkdir -p $1/var/lib/rpm
>>+ rpm --root "$1" --initdb
>>+ rpm --root "$1" --rebuilddb
>>+}
>>
>>
>
>see above; rpm-db MUST NOT be under /.../. Using the 'rpm.initDB'
>function should suffice.
>
>
>
I had some troubles using rpm.initDB. It never generates the rpmdatabase
because of a mount -bind.
Even more strange, the rpm database provided is not working with urpmi.
I agree to change the paths but please keep use the real rpm call.
>are you really sure, that you need this hack for urpmi also?
>
>
I don't think so, I've kept that from yum.
>>diff -Nrub usr/lib/util-vserver/vserver-build.urpmi /usr/lib/util-vserver/vserver-build.urpmi
>>--- scripts/vserver-build.urpmi 1970-01-01 01:00:00.000000000 +0100
>>+++ scripts/vserver-build.urpmi 2005-02-19 18:02:40.343370128 +0100
>>...
>>+urpmi.initDB "$VDIR"
>>
>>
>
>see above; 'rpm.initDB' should suffice.
>
>
>
Using today rpm fake it doesn't seems. Please keep that.
>Btw... is this really needed? DNS should carry information about your
>hostname so an extra /etc/hosts entry seems to be superfluously (except
>for the DNS server).
>
>
>
It was not really necessary for urpmi. A rest of a personal hack. sorry.
>
>
>>--- scripts/vserver-build~ 2005-02-19 18:31:29.202699861 +0100
>>+++ scripts/vserver-build 2005-02-19 18:37:36.595585034 +0100
>>@@ -56,6 +56,9 @@
>> yum ... -- -d <distribution>
>> ... installs the base-packages of the given distribution with
>> help of 'vyum'
>>+ urpmi ... -- -d <distribution>
>>+ ... installs the base-packages of the given distribution with
>>+ help of 'vurpmi'
>>
>>
> ~~~~~~
>This program is not part of your patch, right?
>
>
Agreed. Appologies. s/vurpmi/urpmi/
>Thx for the patch
>Enrico
>
>
I'm free to test the cvs integration.
Thx for your experienced proof reading,
Erwan
_______________________________________________
Vserver mailing list
Vserver_at_list.linux-vserver.org
http://list.linux-vserver.org/mailman/listinfo/vserver