From: Herbert Poetzl (herbert_at_13thfloor.at)
Date: Wed 19 Nov 2003 - 09:55:33 GMT
On Tue, Nov 18, 2003 at 07:50:25PM -0400, James MacLean wrote:
> Hi Herbert:
Hi James!
> > I really would appreciate if you could test the following:
> >
> > take a 2.4.23-rc1 as you patched it, _without_ the RT stuff
>
> This one Oopses. Fresh 2.4.22 + 23rc1 patch + vserver-1.1.3.
>
> > and a 2.4.22 with vs1.00 with the RT stuff
>
> This one was Ok, as are the old vservers.
thanks for spotting this one, it turned out
to be a nasty copy/paste error in, as you
concluded in tcp_getinfo() ...
> Sorry I have not had time to write down the complete Oops,
> but the machine is being used so I can only crash it so often ;).
no problem, it was not easy to reproduce, but ..
> Would the fixes in 1.1.4 be worth trying?
no, but applying the following 'trivial' patch will
--- linux-2.4.23-rc1-vs1.1.4/net/ipv4/tcp_ipv4.c Tue Nov 18 23:32:58 2003
+++ linux-2.4.23-rc1-vs1.1.4-fix/net/ipv4/tcp_ipv4.c Wed Nov 19 09:47:36 2003
@@ -2334,7 +2334,7 @@ skip_listen:
tw != NULL;
tw = (struct tcp_tw_bucket *)tw->next, num++) {
if (!TCP_INET_FAMILY(tw->family) ||
- !vx_check(sk->vx_id, VX_WATCH|VX_IDENT))
+ !vx_check(tw->vx_id, VX_WATCH|VX_IDENT))
continue;
pos += TMPSZ;
if (pos <= offset)
expect a vs1.1.5 release soon ...
HTH,
Herbert
> or did they not have any affect on tcp_getinfo ?
>
> Later,
> JES
> --
> James B. MacLean macleajb_at_ednet.ns.ca
> Department of Education
> Nova Scotia, Canada
> B3M 4B2
>
>
> _______________________________________________
> Vserver mailing list
> Vserver_at_list.linux-vserver.org
> http://list.linux-vserver.org/mailman/listinfo/vserver
_______________________________________________
Vserver mailing list
Vserver_at_list.linux-vserver.org
http://list.linux-vserver.org/mailman/listinfo/vserver